Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: replace macOS 10.15 with macOS 11 in CI pipelines #717

Merged
merged 2 commits into from
Aug 12, 2022
Merged

ci: replace macOS 10.15 with macOS 11 in CI pipelines #717

merged 2 commits into from
Aug 12, 2022

Conversation

striezel
Copy link
Contributor

Description

GitHub started the deprecation process for macOS 10.15 runners on 2022-05-31, and macOS 10.15 will be completely unsupported by 2022-08-30 (if things proceed as planned). That is, in less than a month macOS builds would fail permanently, so the corresponding jobs are moved to macOS 11.

References

This issue already hit us during the build for PR #716, because at that time there was a scheduled brownout for macOS 10.15 builds to raise awareness of the upcoming removal. It certainly worked. :D

See actions/runner-images#5583 for more information on the removal of the macOS 10.15 images.

Tasklist

  • Ensure all CI builds pass
  • Review and approve

@striezel
Copy link
Contributor Author

On second thought, it might also be worth to consider the removal of Azure builds altogether.
As things are now, AzP are used for builds with GCC 6 and GCC 8 on Linux and with Xcode 13(?) on macOS 11. However, GCC 6 and 8 are also covered by the GitHub Actions workflow, and macOS builds with Xcode are covered by GHA, too. So there seems to be no benefit to keeping the AzP stuff, as far as toolset coverage is concerned. Or am I missing something? So I could update this PR to remove the Azure stuff, if that is acceptable. Any thoughts on that?

@striezel
ci: replace macOS 10.15 with macOS 11 in CI workflow
905e018 
GitHub started the deprecation process for macOS 10.15 runners
on 2022-05-31, and macOS 10.15 will be completely unsupported by
2022-08-30 (if things proceed as planned).

See <actions/runner-images#5583> for
more information on the removal of the macOS 10.15 images.

This issue already hit us during the build for PR boostorg#716, because
at that time there was a scheduled brownout for macOS 10.15
builds to raise awareness of the upcoming removal.
@striezel
Copy link
Contributor Author

Just updated this PR to only replace the macOS image on GHA. New macOS passed on GHA, but it failed on Azure.

So I will probably add another PR that will remove Azure builds.

@striezel
Copy link
Contributor Author

striezel commented Aug 11, 2022 •
edited
Loading

Even the old macOS version failed on Azure: https://dev.azure.com/boostorg/gil/_build/results?buildId=2042&view=logs&jobId=428b2f5c-d4ea-5628-f40b-db0b1f2cd10b&j=428b2f5c-d4ea-5628-f40b-db0b1f2cd10b&t=a1e26ec1-1cd6-52b3-5716-ab36bddef14c

2022-08-11T17:19:23.8573400Z -- Conan executing: /usr/local/bin/conan install /Users/runner/work/1/s/boost-root/libs/gil/conanfile.txt -s build_type=Release -s compiler=apple-clang -s compiler.version=12.0 -s compiler.libcxx=libc++ -g=cmake --build=missing
2022-08-11T17:19:24.4057570Z Auto detecting your dev setup to initialize the default profile (/Users/runner/.conan/profiles/default)
2022-08-11T17:19:24.4068430Z CC and CXX: None, /Applications/Xcode_12.4.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ 
2022-08-11T17:19:24.4070330Z No compiler was detected (one may not be needed)
2022-08-11T17:19:24.4072520Z ERROR: Not able to automatically detect '/Applications/Xcode_12.4.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++' version
2022-08-11T17:19:24.4074910Z Default settings
2022-08-11T17:19:24.4075950Z 	os=Macos
2022-08-11T17:19:24.4076920Z 	os_build=Macos
2022-08-11T17:19:24.4077890Z 	arch=x86_64
2022-08-11T17:19:24.4078800Z 	arch_build=x86_64
2022-08-11T17:19:24.4080060Z 	build_type=Release
2022-08-11T17:19:24.4080990Z *** You can change them in /Users/runner/.conan/profiles/default ***
2022-08-11T17:19:24.4082620Z *** Or override with -s compiler='other' -s ...s***

macOS 11 failed with a similar error, too: https://dev.azure.com/boostorg/gil/_build/results?buildId=2041&view=logs&j=dbffb207-18be-561b-b0ae-80a806713608&t=c389dadf-49bf-5055-b7a5-f2217ec3ecf5

@mloskot
Copy link
Member

mloskot commented Aug 11, 2022

it might also be worth to consider the removal of Azure builds altogether.

Yes, I think it's desirable to clean this up.
Originally (or AFAIR), the AzP builds were added to build using our contributor-oriented CMake configuration.

However, as we have planned to clean the CI up, indeed, we should strive for usable bare minimum first.

@striezel
Copy link
Contributor Author

Yes, I think it's desirable to clean this up.

Alright. I just pushed another commit that removes the Azure builds.

mloskot
mloskot approved these changes Aug 12, 2022
View reviewed changes
Copy link
Member

@mloskot mloskot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@mloskot mloskot merged commit 1f89d62 into boostorg:develop Aug 12, 2022
@striezel striezel deleted the replace-macos-10.15-in-ci branch August 12, 2022 21:00
@striezel striezel mentioned this pull request Jun 30, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mloskot mloskot mloskot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@striezel @mloskot